Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix subworkflows linting: test passes if component.out.version is found in script #2448

Merged
merged 2 commits into from
Sep 27, 2023
Merged

fix subworkflows linting: test passes if component.out.version is found in script #2448

merged 2 commits into from
Sep 27, 2023

Conversation

mirpedrol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

mashehu
mashehu approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the changelog 😉

@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #2448 (85b0b71) into dev (18fe023) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #2448      +/-   ##
==========================================
+ Coverage   70.66%   70.67%   +0.01%     
==========================================
  Files          87       87              
  Lines        9431     9431              
==========================================
+ Hits         6664     6665       +1     
+ Misses       2767     2766       -1
Files Coverage Δ
nf_core/subworkflows/lint/main_nf.py 9.70% <0.00%> (ø)

... and 1 file with indirect coverage changes

@mashehu mashehu merged commit 42ba2e6 into nf-core:dev Sep 27, 2023
18 checks passed
@mirpedrol mirpedrol deleted the fix-subworkflows-linting branch September 28, 2023 06:41
@mirpedrol mirpedrol restored the fix-subworkflows-linting branch November 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @mashehu